fix(frontend): restore pit-stop markers on strategy stint timeline (#45)

Wire Race Hub pit_stops into TyreStintTimeline via optional per-row
pitStops laps; render vertical markers at stint boundaries with driver/lap
tooltips. Matches pre-extraction positioning ((lap-1)/totalLaps).

Co-authored-by: Cursor <cursoragent@cursor.com>

cmd/main.go

@@ -27,7 +27,6 @@ func main() {
 	ingestMeeting := flag.Int("ingest-meeting", 0, "Ingest meeting metadata and Race Hub datasets for all sessions")
 	ingestSession := flag.Int("ingest-session", 0, "Ingest Race Hub datasets for a session key")
 	ingestNews := flag.Bool("ingest-news", false, "Refresh RSS/Atom paddock briefing feeds")
-	prefetchTrackOutlines := flag.Int("prefetch-track-outlines", 0, "Warm the web track-outline cache for a season year (for web-only hosts, run before --web so /api/v1/track-outline can serve live maps)")
 	dryRun := flag.Bool("dry-run", false, "Preview ingestion without writing domain rows")
 	force := flag.Bool("force", false, "Re-ingest datasets even if already tracked in the session_coverage table as completed")
 	coverageYear := flag.Int("coverage", 0, "Show season coverage report for the given year")
@@ -77,21 +76,11 @@ func main() {
 	if *ingestNews {
 		ingestFlags++
 	}
-	if *prefetchTrackOutlines != 0 {
-		ingestFlags++
-	}
 	if ingestFlags > 0 {
 		if ingestFlags > 1 {
-			fmt.Fprintln(os.Stderr, "box-box: only one of --ingest-year, --backfill-season, --ingest-meeting, --ingest-session, --ingest-news, or --prefetch-track-outlines may be set")
+			fmt.Fprintln(os.Stderr, "box-box: only one of --ingest-year, --backfill-season, --ingest-meeting, --ingest-session, or --ingest-news may be set")
 			os.Exit(1)
 		}
-		if *prefetchTrackOutlines != 0 {
-			if err := runTrackOutlinePrefetch(client, *prefetchTrackOutlines); err != nil {
-				fmt.Fprintf(os.Stderr, "box-box track outline prefetch error: %v\n", err)
-				os.Exit(1)
-			}
-			return
-		}
 		if *ingestNews {
 			if err := runNewsIngestion(*dryRun, *dbPath); err != nil {
 				fmt.Fprintf(os.Stderr, "box-box ingest error: %v\n", err)
@@ -99,7 +88,7 @@ func main() {
 			}
 			return
 		}
-
+		
 		yearVal := *ingestYear
 		if *backfillSeason != 0 {
 			yearVal = *backfillSeason
@@ -185,35 +174,6 @@ func runIngestion(client *api.OpenF1Client, year, meetingKey, sessionKey int, fo
 	return err
 }
 
-func runTrackOutlinePrefetch(client *api.OpenF1Client, year int) error {
-	log.SetOutput(os.Stderr)
-
-	fmt.Fprintf(os.Stderr, "track outlines: warming HTTP cache %s for %d\n", api.DefaultCacheDBPath(), year)
-
-	meetings, err := client.GetMeetingsForYear(year)
-	if err != nil {
-		return fmt.Errorf("fetch meetings for %d: %w", year, err)
-	}
-
-	result := client.PrefetchTrackOutlinesForYear(year, meetings)
-	fmt.Printf(
-		"track outlines %d: cached %d/%d unique circuit(s) before, %d/%d after; %d skipped, %d fetched, %d failed\n",
-		result.Year,
-		result.CachedBefore,
-		result.UniqueCircuits,
-		result.CachedAfter,
-		result.UniqueCircuits,
-		result.Skipped,
-		result.Fetched,
-		result.Failed,
-	)
-
-	if result.CachedAfter == 0 {
-		return fmt.Errorf("cached zero track outlines for %d", year)
-	}
-	return nil
-}
-
 func runNewsIngestion(dryRun bool, dbPath string) error {
 	log.SetOutput(os.Stderr)
 
@@ -315,7 +275,7 @@ func runCoverageReport(year int, dbPath string) error {
 	}
 
 	fmt.Printf("\n--- Season %d Coverage Report ---\n\n", year)
-	fmt.Printf("%-35s | %-5s | %-2s | %-2s | %-2s | %-2s | %-2s | %-2s | %-2s | %-2s | %-2s\n",
+	fmt.Printf("%-35s | %-5s | %-2s | %-2s | %-2s | %-2s | %-2s | %-2s | %-2s | %-2s | %-2s\n", 
 		"Meeting / Session (Key)", "ID", "DR", "SR", "SG", "ST", "PS", "PO", "RC", "WE", "LA")
 	fmt.Println(strings.Repeat("-", 82))
 

frontend/src/components/StrategyView.tsx

@@ -12,7 +12,7 @@ interface Props {
   hasStints: boolean
 }
 
-export function StrategyView({ results, stints, pit_stops: _pitStops, hasStints }: Props) {
+export function StrategyView({ results, stints, pit_stops, hasStints }: Props) {
   if (!hasStints) {
     return (
       <div>
@@ -88,6 +88,10 @@ export function StrategyView({ results, stints, pit_stops: _pitStops, hasStints
         lapEnd: s.lap_end,
         isNew: s.tyre_age_at_start === 0,
       })),
+    pitStops: pit_stops
+      .filter((p) => p.driver_number === driver.driver_number)
+      .map((p) => p.lap_number)
+      .sort((a, b) => a - b),
   }))
 
   return (

frontend/src/components/charts/TyreStintTimeline.tsx

@@ -12,6 +12,8 @@ export interface StintTimelineRow {
   label: string
   color: string
   stints: StintTimelineStint[]
+  /** Lap numbers where the driver pitted; optional — rows without stops render normally. */
+  pitStops?: number[]
 }
 
 interface TyreStintTimelineProps {
@@ -57,6 +59,14 @@ function stintBarW(stint: StintTimelineStint, totalLaps: number): number {
   return Math.max(2, (stintLength(stint) / totalLaps) * BAR_W)
 }
 
+function pitMarkerX(lapNumber: number, totalLaps: number): number {
+  return LEFT + ((lapNumber - 1) / totalLaps) * BAR_W
+}
+
+function pitMarkerTitle(driverLabel: string, lapNumber: number): string {
+  return `${driverLabel} pit stop · L${lapNumber}`
+}
+
 function axisTicks(totalLaps: number): number[] {
   const ticks: number[] = []
   for (let lap = 0; lap <= totalLaps; lap += 10) {
@@ -130,6 +140,21 @@ export function TyreStintTimeline({ rows, totalLaps }: TyreStintTimelineProps) {
                     <title>{stintTitle(stint)}</title>
                   </rect>
                 ))}
+
+                {(row.pitStops ?? []).map((lapNumber, pi) => (
+                  <line
+                    key={`pit-${pi}`}
+                    x1={pitMarkerX(lapNumber, safeTotal)}
+                    x2={pitMarkerX(lapNumber, safeTotal)}
+                    y1={BAR_Y - 3}
+                    y2={BAR_Y + BAR_H + 3}
+                    className="stint-timeline__pit-marker"
+                    data-testid="pit-marker"
+                    data-lap={lapNumber}
+                  >
+                    <title>{pitMarkerTitle(row.label, lapNumber)}</title>
+                  </line>
+                ))}
               </g>
             )
           })}

frontend/src/styles/stint-timeline.css

@@ -40,6 +40,13 @@
   stroke-dasharray: 2 1;
 }
 
+.stint-timeline__pit-marker {
+  stroke: var(--text);
+  stroke-width: 1.5;
+  opacity: 0.7;
+  pointer-events: stroke;
+}
+
 .stint-timeline__axis-tick {
   font-family: var(--f-mono);
   font-size: 9px;

frontend/src/test/StrategyView.test.tsx

@@ -106,6 +106,17 @@ describe('StrategyView — stints available', () => {
     )
     expect(screen.queryByText(/Stints not available/i)).not.toBeInTheDocument()
   })
+
+  it('maps pit_stops into timeline pit markers for the matching driver', () => {
+    const { container } = render(
+      <StrategyView results={results} stints={stints} pit_stops={pitStops} hasStints={true} />
+    )
+    const markers = container.querySelectorAll('[data-testid="pit-marker"]')
+    expect(markers).toHaveLength(1)
+    expect(markers[0]).toHaveAttribute('data-lap', '19')
+    const titles = [...container.querySelectorAll('title')].map((t) => t.textContent)
+    expect(titles).toContain('HAM pit stop · L19')
+  })
 })
 
 describe('StrategyView — stints missing', () => {

frontend/src/test/tyre-stint-timeline.test.tsx

@@ -71,6 +71,61 @@ describe('TyreStintTimeline', () => {
     expect(screen.getByTestId('stint-timeline-empty')).toBeInTheDocument()
     expect(screen.getByText(/No stint data/i)).toBeInTheDocument()
   })
+
+  it('renders one pit marker per stop at the correct lap position', () => {
+    const rowsWithPits: StintTimelineRow[] = [
+      {
+        label: 'HAM',
+        color: '#E8002D',
+        stints: [{ compound: 'SOFT', lapStart: 1, lapEnd: 18 }],
+        pitStops: [19],
+      },
+      {
+        label: 'VER',
+        color: '#3671C6',
+        stints: [
+          { compound: 'MEDIUM', lapStart: 1, lapEnd: 30 },
+          { compound: 'SOFT', lapStart: 31, lapEnd: 78 },
+        ],
+        pitStops: [31, 52],
+      },
+    ]
+    const { container } = render(
+      <TyreStintTimeline rows={rowsWithPits} totalLaps={78} />,
+    )
+    const markers = container.querySelectorAll('[data-testid="pit-marker"]')
+    expect(markers).toHaveLength(3)
+    expect(markers[0]).toHaveAttribute('data-lap', '19')
+    expect(markers[1]).toHaveAttribute('data-lap', '31')
+    expect(markers[2]).toHaveAttribute('data-lap', '52')
+    expect(container.querySelectorAll('.stint-timeline__bar')).toHaveLength(3)
+  })
+
+  it('positions pit markers using lap_number and includes driver in tooltip', () => {
+    const rows: StintTimelineRow[] = [
+      {
+        label: 'HAM',
+        color: '#E8002D',
+        stints: [{ compound: 'SOFT', lapStart: 1, lapEnd: 18 }],
+        pitStops: [19],
+      },
+    ]
+    const { container } = render(<TyreStintTimeline rows={rows} totalLaps={78} />)
+    const marker = container.querySelector('[data-testid="pit-marker"]') as SVGLineElement
+    expect(marker).toBeTruthy()
+    // lap 19 → x = 48 + (18/78) * 580 ≈ 181.85
+    expect(Number(marker.getAttribute('x1'))).toBeCloseTo(181.85, 1)
+    const titles = [...container.querySelectorAll('title')].map((t) => t.textContent)
+    expect(titles).toContain('HAM pit stop · L19')
+  })
+
+  it('leaves rows without pit data unchanged', () => {
+    const { container } = render(
+      <TyreStintTimeline rows={sampleRows} totalLaps={78} />,
+    )
+    expect(container.querySelectorAll('[data-testid="pit-marker"]')).toHaveLength(0)
+    expect(container.querySelectorAll('.stint-timeline__bar')).toHaveLength(3)
+  })
 })
 
 const results: EnrichedResult[] = [

internal/api/cache.go

@@ -94,12 +94,6 @@ func cacheDBPath() string {
 	return filepath.Join(".cache", "box-box", "cache.db")
 }
 
-// DefaultCacheDBPath returns the HTTP cache database path used by the OpenF1
-// client in both TUI and web modes.
-func DefaultCacheDBPath() string {
-	return cacheDBPath()
-}
-
 // ttlForURL determines the appropriate TTL based on the URL pattern.
 // Returns 0 (CacheTTLForever) for historical data that will never change.
 func ttlForURL(url string) time.Duration {

internal/api/openf1.go

@@ -623,19 +623,6 @@ func (c *OpenF1Client) GetTeamRadio(sessionKey, driverNumber int) ([]models.Team
 // to maximise the chance of finding data quickly.
 var candidateDrivers = []int{1, 11, 44, 16, 55, 4, 14, 63, 81, 24}
 
-// TrackOutlinePrefetchResult summarizes a season track-outline cache warming
-// run. Counts are scoped to the unique non-zero circuit keys in the provided
-// meeting list.
-type TrackOutlinePrefetchResult struct {
-	Year           int
-	UniqueCircuits int
-	CachedBefore   int
-	CachedAfter    int
-	Skipped        int
-	Fetched        int
-	Failed         int
-}
-
 // PrefetchTrackOutlines fetches GPS location data for every circuit in the
 // provided meeting list and stores it in the cache so the track map tab can
 // render during live sessions when the free-tier API is locked.
@@ -645,58 +632,28 @@ type TrackOutlinePrefetchResult struct {
 // Errors per-circuit are silently ignored — this is a best-effort operation
 // and must never block or crash the main UI.
 func (c *OpenF1Client) PrefetchTrackOutlines(meetings []models.Meeting) {
-	year := time.Now().Year()
-	for _, m := range meetings {
-		if m.Year != 0 {
-			year = m.Year
-			break
-		}
-	}
-	_ = c.PrefetchTrackOutlinesForYear(year, meetings)
-}
-
-// PrefetchTrackOutlinesForYear fetches and caches track outlines for unique
-// circuits in the provided meeting list, storing them under the explicit season
-// year. Unlike PrefetchTrackOutlines, it returns accounting suitable for CLI
-// cache-warming workflows.
-func (c *OpenF1Client) PrefetchTrackOutlinesForYear(year int, meetings []models.Meeting) TrackOutlinePrefetchResult {
 	const maxWorkers = 3
 
-	result := TrackOutlinePrefetchResult{Year: year}
-	uniqueByCircuit := make(map[int]models.Meeting)
-	var unique []models.Meeting
+	year := time.Now().Year()
+
+	// Filter to meetings that need fetching.
+	var pending []models.Meeting
 	for _, m := range meetings {
 		if m.CircuitKey == 0 {
 			continue
 		}
-		if _, exists := uniqueByCircuit[m.CircuitKey]; exists {
-			continue
-		}
-		uniqueByCircuit[m.CircuitKey] = m
-		unique = append(unique, m)
-	}
-
-	result.UniqueCircuits = len(unique)
-
-	// Filter to meetings that need fetching.
-	var pending []models.Meeting
-	for _, m := range unique {
 		if _, ok := c.cache.GetTrackOutline(m.CircuitKey, year); ok {
-			result.CachedBefore++
-			result.Skipped++
 			continue // already cached for this season
 		}
 		pending = append(pending, m)
 	}
 
 	if len(pending) == 0 {
-		result.CachedAfter = result.CachedBefore
-		return result
+		return
 	}
 
 	sem := make(chan struct{}, maxWorkers)
 	var wg sync.WaitGroup
-	var mu sync.Mutex
 
 	for _, mtg := range pending {
 		mtg := mtg // capture
@@ -705,34 +662,19 @@ func (c *OpenF1Client) PrefetchTrackOutlinesForYear(year int, meetings []models.
 		go func() {
 			defer wg.Done()
 			defer func() { <-sem }()
-			ok := c.prefetchCircuit(mtg, year)
-			mu.Lock()
-			if ok {
-				result.Fetched++
-			} else {
-				result.Failed++
-			}
-			mu.Unlock()
+			c.prefetchCircuit(mtg, year)
 		}()
 	}
 
 	wg.Wait()
-
-	for _, m := range unique {
-		if _, ok := c.cache.GetTrackOutline(m.CircuitKey, year); ok {
-			result.CachedAfter++
-		}
-	}
-
-	return result
 }
 
 // prefetchCircuit fetches the track outline for a single meeting and stores it.
 // It prefers completed sessions (past date_end) so the data is full and stable.
-func (c *OpenF1Client) prefetchCircuit(mtg models.Meeting, year int) bool {
+func (c *OpenF1Client) prefetchCircuit(mtg models.Meeting, year int) {
 	sessions, err := c.GetSessionsForMeeting(int(mtg.MeetingKey))
 	if err != nil || len(sessions) == 0 {
-		return false
+		return
 	}
 
 	// Pick the best session: prefer a completed race, then any session with
@@ -754,7 +696,7 @@ func (c *OpenF1Client) prefetchCircuit(mtg models.Meeting, year int) bool {
 		}
 	}
 	if bestSession == nil {
-		return false
+		return
 	}
 
 	// Try candidate drivers in order until we find one with enough points.
@@ -764,7 +706,7 @@ func (c *OpenF1Client) prefetchCircuit(mtg models.Meeting, year int) bool {
 			continue
 		}
 		// Store under the circuit key for this year and stop.
-		return c.cache.SetTrackOutline(mtg.CircuitKey, year, locs) == nil
+		_ = c.cache.SetTrackOutline(mtg.CircuitKey, year, locs)
+		return
 	}
-	return false
 }

internal/api/track_outline_prefetch_test.go

@@ -1,109 +0,0 @@
-package api
-
-import (
-	"encoding/json"
-	"net/http"
-	"net/http/httptest"
-	"strconv"
-	"testing"
-	"time"
-
-	"github.com/AmanTahiliani/box-box/internal/models"
-)
-
-func newTrackOutlineTestClient(t *testing.T, srvURL string) *OpenF1Client {
-	t.Helper()
-	t.Setenv("HOME", t.TempDir())
-	t.Setenv("XDG_CACHE_HOME", t.TempDir())
-
-	c := NewOpenF1Client(srvURL, 5*time.Second)
-	c.pacer = &requestPacer{}
-	t.Cleanup(func() { _ = c.Close() })
-	return c
-}
-
-func TestPrefetchTrackOutlinesForYearSkipsCachedAndWritesLocations(t *testing.T) {
-	var sessionsByMeeting = map[string][]models.Session{
-		"202": {
-			{
-				SessionKey:  9002,
-				SessionName: "Race",
-				MeetingKey:  202,
-				CircuitKey:  2,
-				DateEnd:     "2026-01-01T12:00:00+00:00",
-			},
-		},
-	}
-	var sessionsRequested []string
-	var locationsRequested []string
-
-	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		switch r.URL.Path {
-		case "/v1/sessions":
-			meetingKey := r.URL.Query().Get("meeting_key")
-			sessionsRequested = append(sessionsRequested, meetingKey)
-			_ = json.NewEncoder(w).Encode(sessionsByMeeting[meetingKey])
-		case "/v1/location":
-			sessionKey := r.URL.Query().Get("session_key")
-			driverNumber := r.URL.Query().Get("driver_number")
-			locationsRequested = append(locationsRequested, sessionKey+"/"+driverNumber)
-			_ = json.NewEncoder(w).Encode(testLocations(9002, 1, 51))
-		default:
-			t.Fatalf("unexpected request path %s", r.URL.Path)
-		}
-	}))
-	defer srv.Close()
-
-	client := newTrackOutlineTestClient(t, srv.URL)
-	if err := client.Cache().SetTrackOutline(1, 2026, testLocations(9001, 1, 51)); err != nil {
-		t.Fatalf("SetTrackOutline() error = %v", err)
-	}
-
-	result := client.PrefetchTrackOutlinesForYear(2026, []models.Meeting{
-		{MeetingKey: 101, Year: 2026, Circuit: models.Circuit{CircuitKey: 1}},
-		{MeetingKey: 202, Year: 2026, Circuit: models.Circuit{CircuitKey: 2}},
-		{MeetingKey: 303, Year: 2026, Circuit: models.Circuit{CircuitKey: 2}},
-	})
-
-	if result.UniqueCircuits != 2 {
-		t.Fatalf("UniqueCircuits = %d, want 2", result.UniqueCircuits)
-	}
-	if result.CachedBefore != 1 || result.Skipped != 1 || result.Fetched != 1 || result.Failed != 0 || result.CachedAfter != 2 {
-		t.Fatalf("unexpected result: %+v", result)
-	}
-	if got, want := len(sessionsRequested), 1; got != want {
-		t.Fatalf("sessions requested %d time(s), want %d: %v", got, want, sessionsRequested)
-	}
-	if sessionsRequested[0] != "202" {
-		t.Fatalf("requested meeting %s, want 202", sessionsRequested[0])
-	}
-	if got, want := len(locationsRequested), 1; got != want {
-		t.Fatalf("locations requested %d time(s), want %d: %v", got, want, locationsRequested)
-	}
-	if locationsRequested[0] != "9002/1" {
-		t.Fatalf("requested location %s, want 9002/1", locationsRequested[0])
-	}
-
-	locs, ok := client.Cache().GetTrackOutline(2, 2026)
-	if !ok {
-		t.Fatal("expected circuit 2 outline to be cached")
-	}
-	if len(locs) != 51 {
-		t.Fatalf("cached %d locations, want 51", len(locs))
-	}
-}
-
-func testLocations(sessionKey, driverNumber, count int) []models.Location {
-	locs := make([]models.Location, count)
-	for i := range locs {
-		locs[i] = models.Location{
-			Date:         "2026-01-01T12:00:" + strconv.Itoa(i%60) + "+00:00",
-			DriverNumber: driverNumber,
-			MeetingKey:   202,
-			SessionKey:   sessionKey,
-			X:            float64(i),
-			Y:            float64(i * 2),
-		}
-	}
-	return locs
-}