amantahiliani/box-box
1
0
Fork 0
mirror of https://github.com/AmanTahiliani/box-box.git synced 2026-08-07 11:54:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(#91): reject stale fidelity approvals

Browse Source
This commit is contained in:
Aman Tahiliani
2026-07-29 23:21:39 -04:00
parent 48030a6d7c
commit deda3bc4ad
3 changed files with 44 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/testing.md
View File

@@ -88,7 +88,7 @@ Do not create the file or use `approved` until the owner has reviewed the packet
npm run release:fidelity:verify
```
The verifier checks that the packet exists, the sign-off exists in `HEAD`, and its full candidate SHA names a commit that is an ancestor of the sign-off commit. It also requires the owner, date, and approved decision fields. It intentionally cannot assess visual fidelity or create approval.
The verifier requires the sign-off commit to be `HEAD` and to change only `docs/release/owner-reviews/<version>.md`. Its full candidate SHA must equal `HEAD^`; any code change after approval requires a new owner sign-off. It also requires the owner, date, and approved decision fields. It intentionally cannot assess visual fidelity or create approval.
For a release candidate, `npm run release:fidelity:gate` runs production visual regression first, then capture, packet generation, and owner-evidence verification in that order. It will remain red until the owner has committed the sign-off.