mirror of
https://github.com/AmanTahiliani/box-box.git
synced 2026-08-07 19:56:18 -04:00
feat(race-hub): trustworthy defaults and fan-facing analysis hierarchy (#75)
Make bare /race-hub resolve to a completed session and never open empty post-session analysis for a future race. - Backend: add `default_analysis_session` to the Weekend context. It never resolves to a future session (picks the richest completed session, ties toward the later one; 0 when everything is upcoming). Existing `default_session_key` and deep links are unchanged. - Frontend default resolution prefers the most recently completed weekend (`pickAnalysisFocusMeeting`) and consumes `default_analysis_session`, falling back to the switcher when only upcoming sessions exist. - New `sessionState` lib maps timing + coverage to user language (upcoming/live/preparing/partial/ready/cancelled); the session rail, active sub-bar, and WeekendSwitcher now label states instead of raw x/11 counts. - Future sessions render a purpose-built PreSessionView (expected availability + countdown) instead of empty Winner/Podium/Pole/Strategy/Compare cards. - Analysis navigation regrouped into Story / Analysis / Data & Context; every existing tab is preserved. Diagnostics (renamed from Data Status) is now a secondary action and the raw dataset strip is hidden behind an explicit toggle, so operational coverage no longer precedes fan content. - Loading/error states offer Retry and a path back to Weekend. Tests: Go query tests for future-exclusion; Vitest for default selection, future pre-session, partial state, error/retry, grouped nav, and sessionState; hermetic Playwright for bare/completed/future/return-to-Weekend; new race-hub-future visual snapshots. Seed adds a far-future session inside the Monaco meeting (kept in-meeting so Command Center focus is unaffected). Note: `default_analysis_session` is an additive field on the existing `/weekend` contract (no new endpoint), per the spec's "context contract" scope. Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
@@ -2,6 +2,7 @@ import { test, expect } from '@playwright/test'
|
||||
|
||||
const FULL_SESSION = 9472
|
||||
const CORE_ONLY_SESSION = 9000
|
||||
const FUTURE_SESSION = 9600
|
||||
|
||||
test.describe('Race Hub Weekend Workspace', () => {
|
||||
test('lands on the Overview tab with workspace identity', async ({ page }) => {
|
||||
@@ -91,20 +92,56 @@ test.describe('Race Hub Weekend Workspace', () => {
|
||||
await expect(page.getByTestId(`rh-switcher-session-${FULL_SESSION}`)).toBeVisible()
|
||||
})
|
||||
|
||||
test('Data Status tab points at admin instead of inline CLI hints', async ({ page }) => {
|
||||
test('Diagnostics is a secondary action and points at admin, not inline CLI hints', async ({ page }) => {
|
||||
await page.goto(`/race-hub?session_key=${CORE_ONLY_SESSION}`)
|
||||
await page.getByRole('tab', { name: 'Data Status' }).click()
|
||||
await page.getByRole('tab', { name: 'Diagnostics' }).click()
|
||||
|
||||
await expect(page.getByTestId('rh-data-status')).toBeVisible()
|
||||
await expect(page.getByRole('link', { name: /manage ingestion/i })).toHaveAttribute(
|
||||
'href',
|
||||
'/admin',
|
||||
)
|
||||
// Raw coverage strip stays hidden until explicitly requested.
|
||||
await expect(page.getByTestId('rh-dataset-strip')).toHaveCount(0)
|
||||
await page.getByTestId('rh-diagnostics-toggle').click()
|
||||
await expect(page.getByTestId('rh-dataset-strip')).toBeVisible()
|
||||
})
|
||||
|
||||
test('bare /race-hub redirects to the focus session', async ({ page }) => {
|
||||
test('groups analysis navigation into Story, Analysis, and Data & Context', async ({ page }) => {
|
||||
await page.goto(`/race-hub?session_key=${FULL_SESSION}`)
|
||||
await expect(page.getByTestId('rh-tabgroup-story')).toBeVisible()
|
||||
await expect(page.getByTestId('rh-tabgroup-analysis')).toBeVisible()
|
||||
await expect(page.getByTestId('rh-tabgroup-context')).toBeVisible()
|
||||
})
|
||||
|
||||
test('bare /race-hub resolves to a completed session, never a future one', async ({ page }) => {
|
||||
await page.goto('/race-hub')
|
||||
await expect(page).toHaveURL(/session_key=\d+/)
|
||||
await expect(page.getByTestId('race-hub')).toBeVisible()
|
||||
// It must not land on the future session.
|
||||
await expect(page).not.toHaveURL(new RegExp(`session_key=${FUTURE_SESSION}`))
|
||||
})
|
||||
|
||||
test('explicit completed session deep link stays stable and shows analysis', async ({ page }) => {
|
||||
await page.goto(`/race-hub?session_key=${FULL_SESSION}`)
|
||||
await expect(page).toHaveURL(new RegExp(`session_key=${FULL_SESSION}`))
|
||||
await expect(page.getByTestId('rh-overview')).toBeVisible()
|
||||
})
|
||||
|
||||
test('explicit future session renders the pre-session view, not empty analysis', async ({ page }) => {
|
||||
await page.goto(`/race-hub?session_key=${FUTURE_SESSION}`)
|
||||
await expect(page.getByTestId('race-hub')).toBeVisible()
|
||||
await expect(page.getByTestId('rh-presession')).toBeVisible()
|
||||
await expect(page.getByTestId('rh-overview')).toHaveCount(0)
|
||||
})
|
||||
|
||||
test('returning to Weekend from an analysis view preserves the meeting context', async ({ page }) => {
|
||||
await page.goto(`/race-hub?session_key=${FULL_SESSION}`)
|
||||
await page.getByRole('tab', { name: 'Strategy' }).click()
|
||||
|
||||
await page.getByTestId('rh-switch-weekend').click()
|
||||
await expect(page.getByTestId('rh-switcher')).toBeVisible()
|
||||
// The current session remains reachable/selected from the switcher.
|
||||
await expect(page.getByTestId(`rh-switcher-session-${FULL_SESSION}`)).toBeVisible()
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user